Goals:
- Reduce Gossip Flakes
- time.sleep in gossip tests
- remove data races
Gossip Flakes
The general concept of gossip is is that nodes pass data around. It is not necessarily 100% foolproof to get messages through.
Unfortunately a lot of the tests behave as if the implementation can never fail.
Connection Management
dup as
TestBasic FAB-13539
Assignee:Morgan Bauer
- Bi-directional connections, one side hangs up the other. Additional connection racing like the below TestAccept case, which is uni-directional.
Test Accept:
Assignee: Swetha Repakula
- Same client makes two connections, does not finish servicing connection before second one comes in, causing a race
- Possible Solution:
- Separate outgoing and incoming versions of the connection -> so that if we see a second incoming we don’t cancel the first incoming
- https://jira.hyperledger.org/browse/FAB-15486
Observations on Connection (gossip/comm/conn.go).connection
- stopFlag (atomic) and stopCh manage whether the connection is being closed - > We should use one or the other, not both. I think with the way most of the code is, we need the stopCh, so we should get rid of the toDie() function and select on the stopCh as appropriate
- Two peers try to make a connection to each other at the same time, will end up with both connections being closed. Solution: make a deterministic decision on which peer should drop the connection and who should keep making the connection. Logic is in getConnection. Assignee: Swetha Repakula
DeMultiplexer
Code isn't safe to call multiple times. Rewritten in whole. Same interface.