This is an aggregation of three proposed release strategies:
- Proposal: Avoid Cherry Picked Releases
- Proposal: Quarterly releases from main by default
- Proposal: Create a Release Candidate for every release
The gist of this proposal is that we always release besu from a release branch, and that release branch only pulls commits from main.
Principles and Benefits
- main should always be release-able
- a chain of commits in the release branch from main provide provenance of a release
- the ability to merge PRs into main is uninhibited by the release process, and the release process itself is not encumbered by changes to main
- the RC process provides a crisp delineation of burn-in build artifacts and final release artifacts
- cherry-picking commits to compose a release remains possible, if discouraged
Example Release Workflow for a hypothetical HL Besu
...
24.7.3
Burn-in candidate release steps (Day 0)
- Create a PR against main to bump the build version to 23.7.4-SNAPSHOT and add a new version section to CHANGELOG.md to reflect the next snapshot revision
- This prevents blocking main during the release but creates a bookmark to indicate that the release will include up to the commit before this.
- Create a release candidate PR which merges `main` as of the release point into the `release` branch, which also updates the build version to reflect 23.7.3-RC
- During the actual 23.7.3 release, it became clear that the only way to do this nicely is by cherry-picking the commit range from main onto the release branch, e.g.
git cherry-pick 6dc10a9..eef40bd
- Due to 1, we need to use a subset of main commits, not including the bump to 23.7.4-SNAPSHOT
- During the actual 23.7.3 release, it became clear that the only way to do this nicely is by cherry-picking the commit range from main onto the release branch, e.g.
- Upon merge into the release branch, CI builds and publishes the necessary artifacts for the release candidate Deploy canary and burn-in builds with the published release candidate artifacts
- `release-<version>` branch.
- When release branch exists and is tagged, any pre-release activities may commence. This usually includes executing a long-running (about 48 hours) "burn in" process which deploys new nodes to sync from scratch on a variety of networks, using a variety of CL clients.
- At this point, there is no published artifact, and testing may take as long as deemed necessary.
Final release steps (Day X)
Upon successful validation of the release candidate burn-in:
- create Define a new release on GitHub using the <version> for the release.
- PR against the release branch to update ONLY the build version to 23.7.3, removing the -RC suffixupon successful build and merge of the release PR:
- draft a new github release for 23.7.3
- wait for docker artifacts to build and publish <version>
- publish publish the github release with artifact SHAs and announce on HL discord. This will create a new release and all artifacts will be versioned based on the string in the name of the release.
- build artifacts will be attached to the release, and accurate SHAs and docker locations will be amended.
Burn-in failures and hotfixes
An alternate outcome where the burn-in fails is a no-op. Nothing needs to happen except the same process to build a new release candidate with a new version. We skip 23.7.3, note in CHANGELOG.md that it failed burn-in, and move on to 23.7.4.to 'cancel the release'. We can either skip this release version (and note that outcome in CHANGELOG.md), or build an RC2 candidate by restarting the burn-in candidate steps at step #2 with the new RC number.
This process leaves a cherry-pick escape hatch for hotfixes that is minimum friction for the latest release at least. The biggest element of friction here is the PR which merges main into the release would need to handle the merge conflict that a cherry-pick creates. This implies that it would be desirable for cherry-picking should to be a rare event, that is done with care.
Currently Trialing this process with 23.7.x
We have been trialing this process for the 23.7.x series of releases, and have encountered essentially all of the scenarios described above. 23.7.0 was a simple merge of main into a new release branch. However, 23.7.0 failed burn-in, and 23.7.1 was a fast-follow cherry-pick release. 23.7.2 had to account for this cherry pick and the PR to merge main was higher than desired friction. 23.7.3 should be another low friction release. In all of these, `main` branch development was unimpeded and the release process was not affected by it.
Comments, feedback, and clarification are all welcome.